doc: update Bitcoin Core version references and remove outdated comments#80
Conversation
xyephy
commented
Jan 19, 2026
xyephy
commented
- Update minimum required Bitcoin Core version from v30.0 to v30.2
- Update interruptWait() comment to be version-agnostic since v30.2 now implements it
- Remove outdated comment about IPC bypassing blockreservedweight minimum enforcement (no longer accurate)
xyephy
force-pushed
the
2026/01/update-v30-comments
branch
from
1a1a57d to
26483dd
Compare
src/sv2/template_provider.cpp
Outdated
| } catch (const ipc::Exception& e) { | ||
| // Bitcoin Core v30 does not yet implement interruptWait(), fall back | ||
| // to just waiting until waitNext() returns. | ||
| // Older Bitcoin Core versions may not implement interruptWait(), |
There was a problem hiding this comment.
If we declare that v30.2 is the minimum version, then we should drop this exception handling entirely. Or we could keep it just in case, but the comment should make that more clear.
There was a problem hiding this comment.
yes we can drop it and add more detailed comments to remove confusion.
xyephy
force-pushed
the
2026/01/update-v30-comments
branch
2 times, most recently
from
ebcc647 to
6cb2743
Compare
|
Thanks. Can you split the PR into two commits, one that changes the code and a second that updates the documentation? |
| t.second.second->interruptWait(); | ||
| } | ||
| } catch (const ipc::Exception& e) { | ||
| // Bitcoin Core v30 does not yet implement interruptWait(), fall back |
There was a problem hiding this comment.
In the commit message for the first commit, it's good to mention that interrupteWait() was added to Bitcoin Core v30.1 in bitcoin/bitcoin#33609
|
@xyephy do you have time to split the commit in the next few days? |
yes, will split it and push. Thank you |
interruptWait() was added to Bitcoin Core v30.1 in bitcoin/bitcoin#33609. Since v30.2 is the minimum required version, the fallback for missing interruptWait() is no longer needed.
Update README.md and doc/stratum-v2.md to reflect that Bitcoin Core v30.2 is the minimum required version.
xyephy
force-pushed
the
2026/01/update-v30-comments
branch
from
6cb2743 to
1bed3b0
Compare
|
@Sjors I noticed merged commit 266127d, the comment says "Bitcoin Core enforces a minimum block reserved weight of 2000" but |
Use std::max so block_reserved_weight enforces the 2000 weight minimum rather than capping at 2000. Add a focused regression test that covers the floor behavior and documents the min-vs-cap failure mode. Reported by xyephy: stratum-mining#80 (comment) Assisted-by: OpenAI GPT-5.3-Codex
|
Oops, fixed in #82. |
Use std::max so block_reserved_weight enforces the 2000 weight minimum rather than capping at 2000. Add a focused regression test that covers the floor behavior and documents the min-vs-cap failure mode. Reported by xyephy: stratum-mining#80 (comment) Assisted-by: OpenAI GPT-5.3-Codex
2 participants
